Attention is currently required from: Jason Glenesk, Raul Rangel, Paul Menzel.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54638 )
Change subject: soc/amd/cezanne: Add pre-FSPM call to the mainboard
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/cezanne/fsp_m_params.c:
https://review.coreboot.org/c/coreboot/+/54638/comment/9ed51830_7fd2a57b
PS1, Line 39: __weak void mb_pre_fspm(void)
i'd prefer the current code over init_gpios_before_psp. also: did you mean fsp? […]
Absolutely. Thanks for being flexible here. As I said, I don't disagree with you.
And yes, I meant FSP, not PSP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37d2625ff426347852e98a9a50f15368e0213449
Gerrit-Change-Number: 54638
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 31 May 2021 15:14:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment