Attention is currently required from: Jérémy Compostella, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83316?usp=email )
Change subject: soc/intel/common/block/gpio/gpio.c: Improve GPIO debug infos ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/83316/comment/633f735d_62529920?usp... : PS6, Line 196: printk(BIOS_DEBUG, "GPE_EN[0x%02x, %02zu]: Reg: 0x%x, Value = 0x%08x\n",
zu is used to print unsigned size_t. […]
Done
https://review.coreboot.org/c/coreboot/+/83316/comment/30989beb_0ac5797f?usp... : PS6, Line 399: pcr_read32(comm->port, PAD_CFG_OFFSET(config_offset, i))); /* updated value */
I moved the printk function after pcr_write so that it can print the value after writting.
Done