Attention is currently required from: Furquan Shaikh, Martin Roth, Tim Wawrzynczak. Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52747 )
Change subject: util/sconfig: Add support for discontiguous FW_CONFIG fields ......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3: Please update Documentation/lib/fw_config.md to reflect the new format and perhaps provide an example in there.
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/52747/comment/a85dd14d_96d3e672 PS3, Line 598: ((1ull << (1ull + bits->end_bit - bits->start_bit)) - 1ull); could pull this into a function that takes fw_config_field_bits since it is used in multiple places now.
File util/sconfig/sconfig.h:
https://review.coreboot.org/c/coreboot/+/52747/comment/0bb96e8b_93836de7 PS3, Line 230: append_bits I would suggest adding fw_config in the name to match all the other fw_config callbacks. (although it is pretty evident from the 1st argument..)