Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31593 )
Change subject: mb/emulation/qemu: Fix fw_cfg regression
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Thanks for chasing this down!
https://review.coreboot.org/#/c/31593/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31593/1//COMMIT_MSG@7
PS1, Line 7: mb/emulation/qemu: Fix fw_cfg regression
You are not fixing a regression, you are fixing ACPI
(table loading). The regression is the reason to fix
something.
https://review.coreboot.org/#/c/31593/1//COMMIT_MSG@9
PS1, Line 9: The change I48cc943aaa999e4323e9d7e5dd666c5316533dcc
Please use a (shortened) commit hash.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibacbf7caab9be5f181c12e9dd39a2893b13cf6c9
Gerrit-Change-Number: 31593
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 23 Feb 2019 11:08:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment