Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35639 )
Change subject: coreboot_table: Use fmap_locate_area_as_rdev() for fmap_offset ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35639/3/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/35639/3/src/lib/coreboot_table.c@27... PS3, Line 279: "FMAP",
Does anyone else find this sort of silly? Using fmap to find fmap. I think this is fine, but it certainly makes me chuckle.
Yes!! That is the reason I used FMAP_OFFSET in the first iteration of this patch. But since I got 2 comments asking to switch to fmap_locate_area_as_rdev(), I updated it. I can go back to FMAP_OFFSET since I liked it more :P.
(https://review.coreboot.org/c/coreboot/+/35639/1/src/include/fmap.h#53)
Makes me wonder: what payload or application is using this parameter? It could be deprecated in the future, I suppose?
Like Aaron said, on Chrome OS it was depthcharge. I am not sure if any other payload cares about it. We can eventually deprecate it if no one cares about knowing the fmap offset in flash.