Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34914 )
Change subject: soc/amd/common: Add AcpiMmio access for SMBus PCI device ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34914/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34914/4//COMMIT_MSG@9 PS4, Line 9: 0xfed80000 0xfed80a00
https://review.coreboot.org/c/coreboot/+/34914/4/src/soc/amd/common/block/ac... File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/34914/4/src/soc/amd/common/block/ac... PS4, Line 69: 0xfed80000 0xfed80a00
https://review.coreboot.org/c/coreboot/+/34914/4/src/soc/amd/common/block/ac... PS4, Line 73: ACPIMMIO_SM_PCI_BASE Why not ACPIMMIO_SMB_PCI_BASE? "SM" could be confused with system management (SMM).