Attention is currently required from: Cliff Huang.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81330?usp=email )
Change subject: include/device/pci_ids.h: Add DIDs for MTL Touch controller
......................................................................
Patch Set 4:
(1 comment)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/81330/comment/b7f5bc9d_a34d6a77 :
PS4, Line 4726: PCI_DID_INTEL_MTL_THC0_2
If this is THC0 in SPI mode, it would've been nice to name this `PCI_DID_INTEL_MTL_THC0_SPI`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81330?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1b98fdbd8d8588492bcafa0f3998818dc83ff1d9
Gerrit-Change-Number: 81330
Gerrit-PatchSet: 4
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jingyuan Liang
jingyliang@google.com
Gerrit-Reviewer: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Henry Barnor
hbarnor@chromium.org
Gerrit-CC: Shaunak Saha
shaunak.saha@intel.com
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Comment-Date: Sun, 28 Apr 2024 11:57:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment