[coreboot-gerrit] Change in ...coreboot[master]: inteltool: Move GPIOs to c files per platform

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31504 )

Change subject: inteltool: Move GPIOs to c files per platform
......................................................................

Patch Set 34:

(2 comments)

https://review.coreboot.org/#/c/31504/34/util/inteltool/gpio.h 
File util/inteltool/gpio.h:

PS34: 
Why mix these two different models in one file?

https://review.coreboot.org/#/c/31504/34/util/inteltool/platform_apollolake.... 
File util/inteltool/platform_apollolake.h:

PS34: 
You don't need one header file per platform. You could gather the declarations
in a single file instead. If they are only used in one compilation unit, you
could also move these declarations there.