[coreboot-gerrit] Change in ...coreboot[master]: soc/intel: Fix for missing mem_rank info in SMBIOS

[Francois Toguo Fotso (Code Review)]

Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31235 )

Change subject: soc/intel: Fix for missing mem_rank info in SMBIOS
......................................................................

Patch Set 5:

(5 comments)

Guys,

You review comments/suggestions have been implememted.
Please take a look.

Regards
Francois

https://review.coreboot.org/#/c/31235/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31235/1//COMMIT_MSG@7 
PS1, Line 7: Fix for missing  mem_rank info in SMBIOS
> Please add a prefix (cf. […]

Done

https://review.coreboot.org/#/c/31235/1//COMMIT_MSG@10 
PS1, Line 10: None
> b:122329046

Done

https://review.coreboot.org/#/c/31235/1//COMMIT_MSG@11 
PS1, Line 11: Boot to OS:
> Is rank reported correctly in SMBIOS?

Done

https://review.coreboot.org/#/c/31235/1//COMMIT_MSG@12 
PS1, Line 12:
> BRANCH=octopus

Done

https://review.coreboot.org/#/c/31235/1/src/soc/intel/skylake/romstage/romst... 
File src/soc/intel/skylake/romstage/romstage_fsp20.c:

https://review.coreboot.org/#/c/31235/1/src/soc/intel/skylake/romstage/romst... 
PS1, Line 124: m
> Is this the right field name?

Done