Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37757 )
Change subject: libpayload: cbgfx: Support drawing a box with rounded corners ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37757/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/37757/2/payloads/libpayload/drivers... PS2, Line 332: /* Step 2: Draw rounded corners : * When has_thickness, only the border is drawn. With fixed thickness, : * the time complexity is linear to the size of the box. : */
Please use the comment styles listed in the coding style.
Done
https://review.coreboot.org/c/coreboot/+/37757/2/payloads/libpayload/drivers... PS2, Line 345: uint64_t x, y, yy;
Why not just use the native types? long and so on?
To be consistent with types in 'struct vector'.
https://review.coreboot.org/c/coreboot/+/37757/2/payloads/libpayload/drivers... PS2, Line 351: /* The inequality is valid in the beginning of each iteration: : * y^2 + x_end^2 < r^2 : */
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/37757/2/payloads/libpayload/drivers... PS2, Line 362: /* Example sequence of (y, x) when s = (4, 4) and : * r = (5, 5): : * [(4, 0), (4, 1), (4, 2), (3, 3), (2, 4), : * (1, 4), (0, 4)]. : * If s.x==s.y r.x==r.y, then the sequence will be : * symmetric, and x and y will range from 0 to (r-1). : */
Ditto.
Done