Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33394 )
Change subject: stage_cache: Add into stage_cache if !CONFIG_NO_STAGE_CACHE
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33394/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33394/1//COMMIT_MSG@7
PS1, Line 7: Add into stage_cache if !CONFIG_NO_STAGE_CACHE
Why? This never the case on those platforms afaict.
stage_cache_add() exist inside ext_stage_cache.c or cbmem_stage_cache.c, do you think it make sense to call stage_cache_add() function in case of !CONFIG_NO_STAGE_CACHE ?
it will eventually call __weak implementation ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33394
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e10ef2d261f9b204cecbeae6f65fda037753534
Gerrit-Change-Number: 33394
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 11 Jun 2019 13:58:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment