Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39099 )
Change subject: mb/asus/p8h61-m_lx3_r2_0: Add new mainboard
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39099/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39099/5//COMMIT_MSG@22
PS5, Line 22: - Realtek GbE (coreboot must set the MAC address)
assume this means via VPD or CBFS file?
https://review.coreboot.org/c/coreboot/+/39099/4/src/mainboard/asus/p8h61-m_...
File src/mainboard/asus/p8h61-m_lx3_r2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/39099/4/src/mainboard/asus/p8h61-m_...
PS4, Line 20: select USE_NATIVE_RAMINIT
It won't build though, non-native raminit needs an additional function to fill the pei_data struct.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39099
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I385ee72673202d896041209ff2911995307cb6af
Gerrit-Change-Number: 39099
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 Apr 2020 16:06:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment