Attention is currently required from: Furquan Shaikh, EricR Lai. Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50091 )
Change subject: mb/google/guybrush: First pass GPIO configuriation for Guybrush ......................................................................
Patch Set 5:
(8 comments)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/50091/comment/eda87de6_ce1394cb PS5, Line 17: PAD_NC(GPIO_3),
GSC_SOC_INT_L
I was planning a second pass to fill these in.
https://review.coreboot.org/c/coreboot/+/50091/comment/b1587f57_b3469ace PS5, Line 19: PAD_NC(GPIO_4),
SOC_PEN_DETECT_ODL
Ack
https://review.coreboot.org/c/coreboot/+/50091/comment/a56e4b2b_a7054324 PS5, Line 21: PAD_NC(GPIO_5),
EN_PP5000_EN
Ack
https://review.coreboot.org/c/coreboot/+/50091/comment/c1db3322_8c799074 PS5, Line 23: PAD_NC(GPIO_6),
EN_PP3300_WLAN
Ack
https://review.coreboot.org/c/coreboot/+/50091/comment/a385334f_86ce8ab8 PS5, Line 25: PAD_NC(GPIO_7),
EN_PP3300_TCHPAD
Ack
https://review.coreboot.org/c/coreboot/+/50091/comment/b79849a8_7566594e PS5, Line 27: PAD_NC(GPIO_8),
EN_PWR_WWAN_X
Ack
https://review.coreboot.org/c/coreboot/+/50091/comment/3d399b73_3ba015ac PS5, Line 29: PAD_NC(GPIO_9),
SOC_TCHPAD_INT_L
Ack
https://review.coreboot.org/c/coreboot/+/50091/comment/8cfc0fd5_cefa4b73 PS5, Line 33: PAD_NC(GPIO_11),
SOC_FP_RST_L
Ack