7 Oct
2019
7 Oct
'19
7:08 p.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35824 )
Change subject: arch/x86: Don't allow separate verstage to boot from romcc bootblock ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35824/1/src/arch/x86/bootblock_simp... File src/arch/x86/bootblock_simple.c:
https://review.coreboot.org/c/coreboot/+/35824/1/src/arch/x86/bootblock_simp... PS1, Line 30: #if CONFIG(VBOOT_SEPARATE_VERSTAGE)
Should we #error out here in this configuration? Or silently not honor the Kconfig? Or add the dep […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/35824
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f963a27f9023fd4c6ebc418059d57e00e4dfb4c
Gerrit-Change-Number: 35824
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-Comment-Date: Mon, 07 Oct 2019 19:08:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment