Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46437 )
Change subject: mb/volteer: New variant for Volteer reworked with Dauntless
......................................................................
Patch Set 6: Code-Review+1
I think if you could figure out how to do this using the new REWORK_ID mechanism (b/170385859) being planned instead of creating a new variant, that would be a plus (a device reworked with a dauntless TPM would set a bit indicating it has the "dauntless TPM" rework in the CBI, code can read at runtime and act accordingly). New variants carry extra weight (need Fit images, adds time to builds, etc) that is good to avoid if possible.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46437
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdcd6c2ce3941c229518f21f0e479890b5d76dd1
Gerrit-Change-Number: 46437
Gerrit-PatchSet: 6
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 23 Oct 2020 18:39:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment