Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45399 )
Change subject: soc/mediatek/mt8192: add pmic MT6359P driver ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/mt6359p.h:
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/inc... PS1, Line 1: * : * This file is part of the coreboot project. : * : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
SPDX header
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/inc... PS1, Line 52: buck_uV
buck_uv
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/inc... PS1, Line 53: unsigned int
u32 to be consistent with the type of buck_uv?
Done