Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48859 )
Change subject: ec/google/chromeec: Guard battery-related ACPI code ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48859/1/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/48859/1/src/ec/google/chromeec/acpi... PS1, Line 266: EC_NO_BATTERY_PRESENT Instead of adding #ifs around this, can we use CondRefOf?
If (CondRefOf (BAT0)) { Notify (BAT0, 0x80) }
Same for other notifications below.
This will ensure that the Debug prints still show up in case the EC for any reason sends these events. I think it is helpful when debugging too.