Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42191 )
Change subject: sb/intel/i82801gx: Use PCI bitwise ops
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42191/4/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801gx/lpc.c:
https://review.coreboot.org/c/coreboot/+/42191/4/src/southbridge/intel/i8280...
PS4, Line 261: ~0x0f
I prefer the old mask: "0xf0"
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42191
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cc3e71723e9b6898e6ec29f0f38b1b3b7446f09
Gerrit-Change-Number: 42191
Gerrit-PatchSet: 8
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jul 2020 17:56:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment