build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43615 )
Change subject: drivers/system76/dgpu: Add driver for System76 switchable graphics ......................................................................
Patch Set 1:
(34 comments)
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/b... File src/drivers/system76/dgpu/bootblock.c:
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/b... PS1, Line 9: static void dgpu_power_enable(int onoff) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... File src/drivers/system76/dgpu/ramstage.c:
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 7: static void dgpu_read_resources(struct device *dev) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 8: printk(BIOS_INFO, "system76: dgpu_read_resources %s\n", dev_path(dev)); Prefer using '"%s...", __func__' to using 'dgpu_read_resources', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 10: pci_dev_read_resources(dev); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 17: struct resource *res; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 32: static void dgpu_enable_resources(struct device *dev) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 33: printk(BIOS_INFO, "system76: dgpu_enable_resources %s\n", dev_path(dev)); Prefer using '"%s...", __func__' to using 'dgpu_enable_resources', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 37: printk(BIOS_INFO, " subsystem <- %04x/%04x\n", dev->subsystem_vendor, dev->subsystem_device); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 38: pci_write_config32(dev, 0x40, ((dev->subsystem_device & 0xffff) << 16) | (dev->subsystem_vendor & 0xffff)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 55: static void dgpu_above_4g(void *unused) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 64: printk(BIOS_INFO, "system76: PEG0 at %p, %04x:%04x\n", pdev, pdev->vendor, pdev->device); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 66: int fn; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 67: for (fn = 0; fn < 8; fn++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 67: for (fn = 0; fn < 8; fn++) { suspect code indent for conditional statements (4, 12)
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 68: struct device *dev; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 70: // Find DGPU functions code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 71: dev = pcidev_path_behind(pdev->link_list, PCI_DEVFN(0, fn)); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 71: dev = pcidev_path_behind(pdev->link_list, PCI_DEVFN(0, fn)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 72: if (dev) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 72: if (dev) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 72: if (dev) { suspect code indent for conditional statements (8, 12)
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 73: printk(BIOS_INFO, "system76: DGPU fn %d at %p, %04x:%04x\n", fn, dev, dev->vendor, dev->device); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 73: printk(BIOS_INFO, "system76: DGPU fn %d at %p, %04x:%04x\n", fn, dev, dev->vendor, dev->device); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 73: printk(BIOS_INFO, "system76: DGPU fn %d at %p, %04x:%04x\n", fn, dev, dev->vendor, dev->device); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 74: dev->ops = &dgpu_pci_ops_dev; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 74: dev->ops = &dgpu_pci_ops_dev; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 75: } else { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 75: } else { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 75: } else { suspect code indent for conditional statements (8, 12)
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 76: printk(BIOS_ERR, "system76: failed to find DGPU fn %d\n", fn); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 76: printk(BIOS_ERR, "system76: failed to find DGPU fn %d\n", fn); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 77: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 77: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43615/1/src/drivers/system76/dgpu/r... PS1, Line 78: } please, no spaces at the start of a line