Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45337 )
Change subject: soc/intel/{cnl,ehl,icl,jsl,skl,tgl}: Make use of common reset code block ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45337/1/src/soc/intel/skylake/reset... File src/soc/intel/skylake/reset.c:
https://review.coreboot.org/c/coreboot/+/45337/1/src/soc/intel/skylake/reset... PS1, Line 25: void do_global_reset(void)
SKL doesn't have CSE, and the reset function looks different.
Its not very different. just that SKL reset.c does an extra step before issuing global reset 1. Check the cse is enable and ME operating mode is normal if not then error and return 2. if normal then only send CSE command for global reset. 3. On failure force global reset using PMC
i believe, we should have this check for all platform