[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/cmn: Store CSE and ISHC version into cbmem table

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74208 )

Change subject: soc/intel/cmn: Store CSE and ISHC version into cbmem table
......................................................................

Patch Set 2:

(11 comments)

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/74208/comment/71869542_f9d424ff 
PS2, Line 206: /*compare if stored cse version is same as current cse*/
```
/*
 * Compare if stored cse version (from the previous boot) is same as current
 * running cse version.
 */
```

https://review.coreboot.org/c/coreboot/+/74208/comment/af4ee69e_564957f3 
PS2, Line 208: 		struct fw_version_resp resp;
add this comment as line #208
```
/*
 * Current running CSE version is different than previous stored CSE version which
 * could be due to CSE update or rollback, hence, need to send ISHC partition
 * info cmd to know the currently running ISH version.
 */
```

https://review.coreboot.org/c/coreboot/+/74208/comment/91aba452_f90aa290 
PS2, Line 210: /*
one space to start the line

https://review.coreboot.org/c/coreboot/+/74208/comment/d8eba236_f772c447 
PS2, Line 210: */
one space to end the line

https://review.coreboot.org/c/coreboot/+/74208/comment/85fa95a5_da21859a 
PS2, Line 224: /*update current cse version*/
```
/* Update the currently running CSE firmware version */
```

https://review.coreboot.org/c/coreboot/+/74208/comment/c40fdb5d_b4f3bd56 
PS2, Line 254: store_cse_version(&(cse_bp->fw_ver));
```
if (CONFIG(DRIVERS_INTEL_ISH))
   store_cse_version(&(cse_bp->fw_ver));
```

https://review.coreboot.org/c/coreboot/+/74208/comment/3331b368_192d4d6b 
PS2, Line 1182: 	store_ishc_version();
```
if (CONFIG(DRIVERS_INTEL_ISH))
   store_ishc_version();
```

File src/soc/intel/common/block/include/intelblocks/cse.h:

https://review.coreboot.org/c/coreboot/+/74208/comment/bd55c517_99c724c9 
PS2, Line 147: pre_cse
prev_cse_fw_version

https://review.coreboot.org/c/coreboot/+/74208/comment/2f0d9468_0a2b30ad 
PS2, Line 148: curr_ish
cur_ish_fw_version

https://review.coreboot.org/c/coreboot/+/74208/comment/321a1328_b37179b1 
PS2, Line 153: curr_cse
cur_cse_fw_version

https://review.coreboot.org/c/coreboot/+/74208/comment/1a9fddd2_7e80b279 
PS2, Line 154: ish_info
ish_partition_info