[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/cmd/block: Implement an API to get firmware partition details

[Sridhar Siricilla (Code Review)]

Attention is currently required from: SRIDHAR SIRICILLA, Haribalaraman Ramasubramanian, Dinesh Gehlot, Rizwan Qureshi, Reka Norman, Kapil Porwal.

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 )

Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details
......................................................................

Patch Set 18:

(2 comments)

File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/74005/comment/05ee1eba_30efc898 
PS18, Line 1226: 			.group_id = MKHI_GROUP_ID_GEN,
               : 			.command = MKHI_BUP_COMMON_GET_BOOT_PARTITION_INFO,
> From the command naming MKHI_BUP_COMMON_GET_BOOT_PARTITION_INFO, it is belong to BUP_COMMON group id […]

BTW, I don't see GET_BOOT_PARTITION_INFO command supported under GEN group.Alsom I see the command structure points to GEN/GET IMAGE FW Version command. Please check details!

https://review.coreboot.org/c/coreboot/+/74005/comment/1d9365fc_d38d7311 
PS18, Line 1231: 
Please add check for prerequisites. I guess this command meant for CSE Lite though it useful for consumer SKU, can CSE Lite RO support the command?