Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47829 )
Change subject: util/cbfstool: Treat region offsets differently than absolute addresses ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47829/9/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/47829/9/util/cbfstool/cbfstool.c@14... PS9, Line 149: return 0;
this doesn't result in an error being propagated to the caller (it just assigns the return value) bu […]
Yeah. I was relying on users spotting the error print above, but I think that might not be the best solution. I can rework this to return error. As you commented, this will require changing semantics at the caller site as well. Given that there are just four callers, it probably won't be too bad.