13 May
2021
13 May
'21
9:13 a.m.
Attention is currently required from: Bao Zheng, Martin Roth, Zheng Bao. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52657 )
Change subject: amdfwtool: Remove the misleading option characters ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Patchset:
PS5: I think this change improves the readability of the code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52657
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b0d53d5e5eb494741b7fac32029cf16cabe66d8
Gerrit-Change-Number: 52657
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Eric Peers epeers@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng fishbaozi@gmail.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Thu, 13 May 2021 15:13:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment