7 Apr
2020
7 Apr
'20
12:23 a.m.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )
Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40250/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40250/2/src/mainboard/google/dedede... PS2, Line 70: register "generic.stop_delay_ms" = "100" Do we need the stop pin for SiS? And if yes, what pin of SiS will be connected since I don't see this info in the spec? Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/40250
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id04c46c763fdf68418bf2e97be4c8bb6bb73c749
Gerrit-Change-Number: 40250
Gerrit-PatchSet: 2
Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Marco Chen marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 07 Apr 2020 03:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment