Attention is currently required from: Sean Rhodes, Andy Pont. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62423 )
Change subject: mb/starlabs/labtop: Change all USB ports to OC0 ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62423/comment/ee6ea4ca_4cfd90c2 PS2, Line 7: mb/starlabs/labtop: Change all USB ports to OC0 What's the reason for this change? I imagine it's based on the schematics; if so, I'd mention this:
As per schematics, all USB ports use OC pin 0.
File src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/62423/comment/23f65b1d_c2dc5344 PS2, Line 114: # Internal Webcam : register "usb2_ports[3]" = "USB2_PORT_MID(OC0)" : # Daughterboard SD Card : register "usb2_ports[5]" = "USB2_PORT_MID(OC0)" : # Internal Bluetooth : register "usb2_ports[9]" = "USB2_PORT_MID(OC0)" Internal ports shouldn't be mapped to overcurrent pins.