Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41985 )
Change subject: acpigen: Add some new helper functions ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41985/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41985/1//COMMIT_MSG@13 PS1, Line 13: of
if?
Done
https://review.coreboot.org/c/coreboot/+/41985/1/src/acpi/acpigen.c File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/41985/1/src/acpi/acpigen.c@1289 PS1, Line 1289: val
nit: Should these be op1 and op2?
Done
https://review.coreboot.org/c/coreboot/+/41985/1/src/include/acpi/acpigen.h File src/include/acpi/acpigen.h:
https://review.coreboot.org/c/coreboot/+/41985/1/src/include/acpi/acpigen.h@... PS1, Line 444: * Get element from package into specified desination op:
'desination' may be misspelled - perhaps 'destination'?
Done
https://review.coreboot.org/c/coreboot/+/41985/1/src/include/acpi/acpigen.h@... PS1, Line 496: rx
tx?
Done