Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45052 )
Change subject: soc/intel/tigerlake: Add Acoustic features ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45052/3/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/45052/3/src/soc/intel/tigerlake/chi... PS3, Line 157: IA,GT,SA,VLCC and FIVR Probably add enums for these?
enum vr_domains { VR_DOMAIN_IA, VR_DOMAIN_GT, VR_DOMAIN_SA, VR_DOMAIN_VLCC, VR_DOMAIN_FIVR, VR_DOMAIN_MAX };
VR_DOMAIN_MAX can be used for FastPkgCRampDisable and SlowSlewRate here and mainboard devicetree can use VR_DOMAIN_* when performing the configuration.
https://review.coreboot.org/c/coreboot/+/45052/3/src/soc/intel/tigerlake/chi... PS3, Line 168: 0 - Fast/2 : * 1 - Fast/4 : * 2 - Fast/8 : * 3 - Fast/16 : */ Add enums for these?
https://review.coreboot.org/c/coreboot/+/45052/3/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45052/3/src/soc/intel/tigerlake/fsp... PS3, Line 259: for (i = 0; i < ARRAY_SIZE(config->SlowSlewRate); i++) Use memcpy here and below?