Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Sridhar Siricilla, Deepti Deshatty, Patrick Rudolph. Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54733 )
Change subject: intel/common/block: Move mainboard api to tcss common block ......................................................................
Patch Set 8:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54733/comment/f41b2e5d_d8ce0b25 PS7, Line 6: : mb/google/volteer:intel/common/block: Move mainboard api to tcss common block
`intel/common/block` is enough of a prefix
Ack
File src/drivers/intel/pmc_mux/conn/chip.h:
https://review.coreboot.org/c/coreboot/+/54733/comment/3b5e8e41_684b72ac PS7, Line 32:
nit: line up with `const struct device... […]
Ack
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/54733/comment/d9790118_a412d4d6 PS5, Line 342: const struct device *get_pmc_mux(void) : { : const struct device *pmc; : const struct device *mux; : : pmc = pcidev_path_on_root(PCH_DEVFN_PMC); : if (!pmc || !pmc->link_list) { : printk(BIOS_ERR, "%s: unable to find PMC device or its mux\n", __func__); : return NULL; : } : : mux = pmc->link_list->children; : return mux; : }
This function isn't required, it can be rolled up into the call to `find_dev_nested_path` below
Ack
https://review.coreboot.org/c/coreboot/+/54733/comment/c4f6cd1d_ab0e4b4c PS5, Line 361: : const struct device *mux = get_pmc_mux(); : : if (!mux || !mux->link_list) { : printk(BIOS_ERR, "%s: unable to find PMC mux device or its connector\n", : __func__); : return NULL; : }
same as above, this won't be required
Ack
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/54733/comment/4d63b1e9_48d7a0e7 PS7, Line 349:
nit: extra blank line
Ack