Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35730 )
Change subject: sb,nb/intel/fsp_rangeley: Rename from xx_DEV_FUNC
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35730/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35730/4//COMMIT_MSG@11
PS4, Line 11: renamed
I made the following comment somewhere in baytrail: […]
Ah ok. The SA (system agent) is a proxy for north cluster and pch a proxy for south cluster. Intel hasn't done a monolithic die since baytrail/braswell iirc.
What are you thoughts about being more descriptive? Let it go? Or at least name rangely or something? It feels odd to me use XXX proper.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35730
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ead2bc5e41a86c9aeef730f5664a30406414c8c
Gerrit-Change-Number: 35730
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Guckian
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Oct 2019 01:08:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment