[coreboot-gerrit] Change in coreboot[master]: cpu/x86: Cache stages for RESET_VECTOR_IN_RAM

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38728 )

Change subject: cpu/x86: Cache stages for RESET_VECTOR_IN_RAM
......................................................................

Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/38728/1/src/cpu/x86/mtrr/nonxip_cac... 
File src/cpu/x86/mtrr/nonxip_cache.c:

https://review.coreboot.org/c/coreboot/+/38728/1/src/cpu/x86/mtrr/nonxip_cac... 
PS1, Line 19: void reserve_non_xip_prog(struct prog *prog); // move me
What is this doing here?

https://review.coreboot.org/c/coreboot/+/38728/1/src/cpu/x86/mtrr/nonxip_cac... 
PS1, Line 65: MTRR_TYPE_WRBACK
> Is this not pretty much the same as in cpu/x86/mtrr/xip_cache. […]

I'm sure you could extract some functionality, but I think it's fine the way it is. It's easy and straight forward to read.