Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35951 )
Change subject: nb/intel/nehalem: Move to C_ENVIRONMENT_BOOTBLOCK ......................................................................
Patch Set 3:
(3 comments)
Patch Set 3:
(4 comments)
Sorry, I'm a little confused by the console setup.
- I don't think we should `select` a console option with a prompt.
- This is more general: If one opts out from bootblock console, does this disable romstage console too? I can't find a romstage call to console_init() on other platforms either. :-/
1. ack 2. cpu/intel/car/romstage.c does console_init() with C_ENVRIRONMENT_BOOTBLOCK.
https://review.coreboot.org/c/coreboot/+/35951/3/src/northbridge/intel/nehal... File src/northbridge/intel/nehalem/Kconfig:
https://review.coreboot.org/c/coreboot/+/35951/3/src/northbridge/intel/nehal... PS3, Line 25: select BOOTBLOCK_CONSOLE
Didn't we decide to leave this choice to the user?
I forgot that this is on by default.
https://review.coreboot.org/c/coreboot/+/35951/3/src/northbridge/intel/nehal... File src/northbridge/intel/nehalem/romstage.c:
https://review.coreboot.org/c/coreboot/+/35951/3/src/northbridge/intel/nehal... PS3, Line 51: console_init();
No console_init() in romstage?
done in cpu/intel/car/romstage.c with C_ENVIRONMENT_BOOTBLOCK, where the expectation is that this is set up in the bootblock
https://review.coreboot.org/c/coreboot/+/35951/3/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/early_pch.c:
https://review.coreboot.org/c/coreboot/+/35951/3/src/southbridge/intel/ibexp... PS3, Line 27: static void early_lpc_init(void)
As usual, I'd prefer to move the bootblock code to `bootblock.c`.
ok