Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85131?usp=email )
Change subject: soc/intel/pantherlake: Bind SoC config VR settings to respective UPD
......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS6:
We probably can find common ground, but that would mean using the lowest common denominator, which to my understanding might undermine the performances. I would think we do not want to go that route.
`b001`, `b004`, and `b00a` are from the Panther Lake H12Xe family, while `b002` is from the PTL H4Xe family. These two families have different IA, GT, and SA I_TRIP_NOM values. If a variant needs to support both families, I need to introduce some software architectural changes. Could you tell me if you have a variant that supports both families?
do you want to push this CL as base for CB:86622 ?
btw, in absence of devicetree override these UPDs would be set as zero aka disable . do you see any risk ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85131?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie72e4725cb97b4af7843a43eeaedd687d28b6752
Gerrit-Change-Number: 85131
Gerrit-PatchSet: 13
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Thu, 27 Feb 2025 17:33:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com