12 May
2021
12 May
'21
11:10 a.m.
Attention is currently required from: Ravi kumar, Taniya Das, Paul Menzel, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47077 )
Change subject: WIP sc7280: Add GPIO driver in coreboot WIP ......................................................................
Patch Set 42:
(1 comment)
File src/soc/qualcomm/sc7280/include/soc/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119110): https://review.coreboot.org/c/coreboot/+/47077/comment/f92b57f1_fbad7666 PS42, Line 92: #define PIN(index, func1, func2, func3, func4) \ Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/c/coreboot/+/47077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibefa2fc04db09f1837f65f5a6d4b8534df040785
Gerrit-Change-Number: 47077
Gerrit-PatchSet: 42
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen shchen@google.com
Gerrit-CC: Taniya Das tdas@codeaurora.org
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: Taniya Das tdas@codeaurora.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Comment-Date: Wed, 12 May 2021 11:10:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment