Attention is currently required from: Patrick Rudolph, Simon Chou, Jonathan Zhang, Johnny Lin, Paul Menzel, Tim Chu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71968 )
Change subject: mb/intel: add ArcherCity CRB support ......................................................................
Patch Set 11:
(25 comments)
File src/mainboard/intel/archercity_crb/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/9a130d40_cdb3ed28 PS11, Line 15: #define PCR_DMI_LPCIOD 0x2770 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/e0e01c1d_53603fd6 PS11, Line 16: #define PCR_DMI_LPCIOE 0x2774 please, no space before tabs
File src/mainboard/intel/archercity_crb/include/sprsp_ac_iio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/d300671b_399b3195 PS11, Line 9: #define CFG_UPD_PCIE_PORT(pexphide, slotimp, slotpsp) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/4bb4e680_67e8e2d7 PS11, Line 11: .SLOTEIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/c7f993f2_8a77b036 PS11, Line 12: .SLOTHPCAP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/22a8b88b_a92f536a PS11, Line 13: .SLOTHPSUP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/3da2a9e6_6e11fab5 PS11, Line 14: .SLOTPIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/5719ed87_143f4595 PS11, Line 15: .SLOTAIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/6c784a0b_75801995 PS11, Line 16: .SLOTMRLSP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/c51df5c4_173682a6 PS11, Line 17: .SLOTPCP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/47b068ed_b3588c08 PS11, Line 18: .SLOTABP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/ef1539c6_0b125de8 PS11, Line 19: .SLOTIMP = slotimp, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/8201c813_cc3ce28c PS11, Line 20: .SLOTSPLS = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/88d2355c_09541494 PS11, Line 21: .SLOTSPLV = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/e1f1b786_6f62c581 PS11, Line 22: .SLOTPSP = slotpsp, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/93e8d139_4aeceaf0 PS11, Line 23: .VppEnabled = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/5144084c_02009c16 PS11, Line 24: .VppPort = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/90496de9_1568b335 PS11, Line 25: .VppAddress = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/fe263195_6a982f35 PS11, Line 26: .MuxAddress = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/6836bf9e_2b2d04a8 PS11, Line 27: .ChannelID = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/f70756d3_5fceed9f PS11, Line 28: .PciePortEnable = 1, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/8ea0580d_f2dc4609 PS11, Line 29: .PEXPHIDE = pexphide, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/c19e243d_cd338005 PS11, Line 30: .HidePEXPMenu = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/67ad096b_a7e722df PS11, Line 31: .PciePortOwnership = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169854): https://review.coreboot.org/c/coreboot/+/71968/comment/65c227ec_c4fd0a42 PS11, Line 32: .RetimerConnectCount = 0, \ please, no space before tabs