Attention is currently required from: Andy Pont. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60165 )
Change subject: ec/starlabs/merlin: Apply EC settings when suspending ......................................................................
Patch Set 11:
(3 comments)
File src/ec/starlabs/merlin/acpi/suspend.asl:
https://review.coreboot.org/c/coreboot/+/60165/comment/9f17857b_80161bb8 PS2, Line 16: _SB.PCI0.LPCB.EC.KLSE = 0x00
`WDMS (_SB.PC00.LPCB.H_EC.KLBS, _SB.PC00.LPCB. […]
Done
File src/ec/starlabs/merlin/acpi/suspend.asl:
https://review.coreboot.org/c/coreboot/+/60165/comment/aff87b75_2085defc PS6, Line 9: /* Store current EC settings */
Suggest amending the comment to /* Store current EC settings in CMOS */ to remove any ambiguity abou […]
Done
https://review.coreboot.org/c/coreboot/+/60165/comment/c1c7d184_3f8c3d1d PS6, Line 10: _SB.PCI0.LPCB.TPLS = _SB.PCI0.LPCB.EC.TPLA
It would make the code more obvious if the names of the ECRAM and corresponding CMOS entries were gi […]
Done