Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39688 )
Change subject: new local repo and the point where I am now with vostro 3360 ......................................................................
Patch Set 1:
(15 comments)
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/Kconfig:
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 1: BOARD_DELL_DELL_SYSTEM_VOSTRO_3360 BOARD_DELL_VOSTRO_3360
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 18: dell_system_vostro_3360 Rename the directory to "vostro_3360" ?
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 22: Dell System Vostro 3360 Just "Vostro 3360"
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 1: BOARD_DELL_DELL_SYSTEM_VOSTRO_3360 BOARD_DELL_VOSTRO_3360
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 2: Dell System Vostro 3360 Just "Vostro 3360"
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 1: * : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ SPDX:
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 1: : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Please use SPDX:
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 23: /* Disable USB ports in S3 by default */ : gnvs->s3u0 = 0; : gnvs->s3u1 = 0; : : /* Disable USB ports in S5 by default */ : gnvs->s5u0 = 0; : gnvs->s5u1 = 0; This can go away
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 1: : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ SPDX:
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 17: : #define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB : #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB : #define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0 These are unused
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/early_init.c:
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 1: : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ SPDX:
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 1: : -- This file is part of the coreboot project. : -- : -- This program is free software; you can redistribute it and/or modify : -- it under the terms of the GNU General Public License as published by : -- the Free Software Foundation; either version 2 of the License, or : -- (at your option) any later version. : -- : -- This program is distributed in the hope that it will be useful, : -- but WITHOUT ANY WARRANTY; without even the implied warranty of : -- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : -- GNU General Public License for more details. : -- SPDX:
-- SPDX-License-Identifier: GPL-2.0-or-later -- This file is part of the coreboot project.
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/gpio.c:
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ SPDX:
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 1: : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ SPDX:
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39688/1/src/mainboard/dell/dell_sys... PS1, Line 1: : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * SPDX:
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */