Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48520 )
Change subject: src/lib: Add Kconfig option for SPD cache in FMAP
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig
File src/lib/Kconfig:
https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig@57
PS1, Line 57: _IN_FMAP
I'm not sure how else one might cache SPD data, but felt like being more explicit was better than le […]
It's a minor nit since it felt redundant. I am okay if you want to go ahead with this name.
https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig@64
PS1, Line 64: RW_SPD_CACHE
this is actually hardcoded in spd_cache. […]
That is strange. Came out empty in Makefile.inc where you are updating the default fmd file?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48520
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee0e7acb01e238d7ed354e3dbab1207903e3a4fc
Gerrit-Change-Number: 48520
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 06:43:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment