Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34752 )
Change subject: arch/x86: Attempt to boot without postcar stage/phase ......................................................................
Patch Set 2:
@Subrata Thanks for emailing me about this commit. We know that having non public conversion is something you like at Intel, but it's not what we do in coreboot.
Please let us continue writing here. If you prefer emails: coreboot@coreboot.org
From your comments I see that you don't care about flash size or boot times. The "benefits" mentioned in the commit message are more like "side effects". The only purpose of this change is to build without a postcar stage as you pointed out.
The question remains why this change is useful to this "open source environment" or "soc users"? For me it looks more like a working Proof-of-Concept, but nothing that somebody would ever make use of in production.
IMHO reasons against this PoC are (thus giving -1): * it touches to much of common x86 code, which add more work for x86 maintainers as they need to understand and take care of this special use case * It adds a feature that has seems to have no benefit * It breaks the assumption of having a postcar tearing down CAR for the only reason of being able to do so * It doesn't update or add documentation