Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5277
-gerrit
commit 2991e4ce575906e8e9a9bc1fc9109887240b8a27 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Fri Feb 21 12:43:07 2014 +1100
vendorcode/amd/agesa/f*: Improve gcccar.inc assembler compatibility.
A comparison with a two's complement in gcccar.inc has dubious GAS/AT&T notation. Clang miss-parses 0x-1 as a invalid hexadecimal number.
Change-Id: I88baa5c2513f062ff309df05916a3832b9bd9bb1 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/vendorcode/amd/agesa/f10/gcccar.inc | 2 +- src/vendorcode/amd/agesa/f12/gcccar.inc | 2 +- src/vendorcode/amd/agesa/f14/gcccar.inc | 2 +- src/vendorcode/amd/agesa/f15/gcccar.inc | 2 +- src/vendorcode/amd/agesa/f15tn/gcccar.inc | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/vendorcode/amd/agesa/f10/gcccar.inc b/src/vendorcode/amd/agesa/f10/gcccar.inc index 61a8d3e..aa3c01f 100644 --- a/src/vendorcode/amd/agesa/f10/gcccar.inc +++ b/src/vendorcode/amd/agesa/f10/gcccar.inc @@ -827,7 +827,7 @@ fam14_disable_stack_hook_exit:
LOCAL node_core_f14_exit
- cmp $0x-1, %si # Has node/core already been discovered? + cmp $-0x1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes
AMD_CPUID $CPUID_MODEL diff --git a/src/vendorcode/amd/agesa/f12/gcccar.inc b/src/vendorcode/amd/agesa/f12/gcccar.inc index d7da81d..212b6b0 100644 --- a/src/vendorcode/amd/agesa/f12/gcccar.inc +++ b/src/vendorcode/amd/agesa/f12/gcccar.inc @@ -821,7 +821,7 @@ fam14_disable_stack_hook_exit:
LOCAL node_core_f14_exit
- cmp $0x-1, %si # Has node/core already been discovered? + cmp $-0x1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes
AMD_CPUID $CPUID_MODEL diff --git a/src/vendorcode/amd/agesa/f14/gcccar.inc b/src/vendorcode/amd/agesa/f14/gcccar.inc index 7037344..1fc9f22 100644 --- a/src/vendorcode/amd/agesa/f14/gcccar.inc +++ b/src/vendorcode/amd/agesa/f14/gcccar.inc @@ -835,7 +835,7 @@ fam14_disable_stack_hook_exit:
LOCAL node_core_f14_exit
- cmp $0x-1, %si # Has node/core already been discovered? + cmp $-0x1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes
AMD_CPUID $CPUID_MODEL diff --git a/src/vendorcode/amd/agesa/f15/gcccar.inc b/src/vendorcode/amd/agesa/f15/gcccar.inc index b20c77e..6891ddc 100644 --- a/src/vendorcode/amd/agesa/f15/gcccar.inc +++ b/src/vendorcode/amd/agesa/f15/gcccar.inc @@ -842,7 +842,7 @@ fam14_disable_stack_hook_exit:
LOCAL node_core_f14_exit
- cmp $0x-1, %si # Has node/core already been discovered? + cmp $-0x1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes
AMD_CPUID $CPUID_MODEL diff --git a/src/vendorcode/amd/agesa/f15tn/gcccar.inc b/src/vendorcode/amd/agesa/f15tn/gcccar.inc index c76ad16..dd76561 100644 --- a/src/vendorcode/amd/agesa/f15tn/gcccar.inc +++ b/src/vendorcode/amd/agesa/f15tn/gcccar.inc @@ -875,7 +875,7 @@ fam14_disable_stack_hook_exit:
LOCAL node_core_f14_exit
- cmp $0x-1, %si # Has node/core already been discovered? + cmp $-0x1, %si # Has node/core already been discovered? jnz node_core_f14_exit # Br if yes
AMD_CPUID $CPUID_MODEL