[coreboot-gerrit] Change in coreboot[master]: sb/intel/bd82x6x: Add legacy mode support to SATA

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39828 )

Change subject: sb/intel/bd82x6x: Add legacy mode support to SATA
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39828/2/src/southbridge/intel/bd82x... 
File src/southbridge/intel/bd82x6x/sata.c:

https://review.coreboot.org/c/coreboot/+/39828/2/src/southbridge/intel/bd82x... 
PS2, Line 146: 0x00
> If we were calling pci_or_config8(), but we aren't. I don't know where […]

From the definition.

```
#if ENV_PCI_SIMPLE_DEVICE
static __always_inline
void pci_update_config8(pci_devfn_t dev, u16 reg, u8 mask, u8 or)
#else
static __always_inline
void pci_update_config8(const struct device *dev, u16 reg, u8 mask, u8 or)
#endif
{
        u8 reg8;

reg8 = pci_read_config8(dev, reg);
        reg8 &= mask;
        reg8 |= or;
        pci_write_config8(dev, reg, reg8);
}
```