Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32861 )
Change subject: device_tree: Switch allocations to xzalloc()
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32861/5/src/lib/device_tree.c
File src/lib/device_tree.c:
https://review.coreboot.org/#/c/32861/5/src/lib/device_tree.c@510
PS5, Line 510: malloc
why not xmalloc?
ok, I can understand that most malloc() here should be xzalloc intead of xmalloc.
But can you clarify why this one is expected to be malloc instead of xzalloc / xmalloc?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32861
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I738f24d550a776653b2becd3d4f7d4d2cb3cc048
Gerrit-Change-Number: 32861
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Jun 2019 09:09:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment