EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39868 )
Change subject: mb/google/deltaur: Return SKU ID info ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39868/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/sku.c:
https://review.coreboot.org/c/coreboot/+/39868/2/src/mainboard/google/deltau... PS2, Line 21: static const uint32_t get_sku_index(void) You need weak this function. We should add it in different variants. Only Deltaur will has detect pin. Deltan just need signed and unsigned.