Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37565 )
Change subject: mb/razer: Add initial support for the Blade Stealth Mercury White (late 2019) ......................................................................
Patch Set 14:
(3 comments)
Thank you all for the review. Updated.
https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade_... File src/mainboard/razer/blade_stealth_icl/Kconfig:
https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade_... PS14, Line 11: select GENERIC_SPD_BIN
GENERIC_SPD_BIN twice.
Done
https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade_... File src/mainboard/razer/blade_stealth_icl/board_info.txt:
https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade_... PS14, Line 2: Board name: Blade Stealth Ice Lake U Mercury White late 2019 (LY320)
This is not the same as the name in Kconfig.name. […]
Yes. The official board name does never say Ice Lake. There is an Ice Lake and a Whiskeylake version tho. So in Kconfig I added the Ice Lake hint.
https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade_... File src/mainboard/razer/blade_stealth_icl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37565/14/src/mainboard/razer/blade_... PS14, Line 167: #+-------------------+---------------------------+
The table formatting is broken, here
Done