Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46437 )
Change subject: mb/google/volteer: New variant for Volteer reworked with Dauntless ......................................................................
Patch Set 11:
(2 comments)
PTAL
https://review.coreboot.org/c/coreboot/+/46437/10/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer2/gpio.c:
https://review.coreboot.org/c/coreboot/+/46437/10/src/mainboard/google/volte... PS10, Line 249: UP_2K
Can you please check the schematics to confirm if there are external pulls on these lines? If yes, t […]
Eric has told me that while the rework disconnects the existing touchscreen and other I2C devices, it leaves 2.2kOhm pullups in place, so I have disabled the internal pullups now.
https://review.coreboot.org/c/coreboot/+/46437/10/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/volteer2/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46437/10/src/mainboard/google/volte... PS10, Line 23: register "common_soc_config.gspi[0].early_init" = "CONFIG(MAINBOARD_HAS_SPI_TPM_CR50)" : register "common_soc_config.i2c[1].early_init" = "CONFIG(MAINBOARD_HAS_I2C_TPM_CR50)"
Adding the entire common_soc_config to overridetree should be fine. […]
Done