Hello Aaron Durbin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32798
to look at the new patch set (#2).
Change subject: src/security/vboot/misc.h Fix clang fail to compile ......................................................................
src/security/vboot/misc.h Fix clang fail to compile
Clang does not recognize dead_code() as termination of execution. It gives this message:
error: control reaches end of non-void function [-Werror,-Wreturn-type]
The error was being encountered even without VBOOT enabled, because the misc.h file is included from many places, including coreboot_table.c.
This change:
(a) provides dummy return values from the dead code paths to keep clang happy. (b) moves the final case of if-else-if statements out of else clause to keep the linter happy.
Signed-off-by: Alan Green avg@google.com Change-Id: I19e0c9ba36f0ea5110480521a5f9afa0112a3137 --- M src/security/vboot/misc.h 1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/32798/2