Attention is currently required from: Patrick Rudolph, Arthur Heymans. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63725 )
Change subject: cpu/x86/64bit: Generate static page tables from an assembly file ......................................................................
Patch Set 3:
(2 comments)
File src/cpu/x86/64bit/pt.S:
https://review.coreboot.org/c/coreboot/+/63725/comment/f5671572_8664097f PS3, Line 27: .quad _GEN_PAGE(0x200000 * 0)
Can you use a macro to reduce the duplication? […]
I was wondering if there was a recursion limit. Thanks for trying. I think it's fine as is.
File src/cpu/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63725/comment/1f821ead_c7980acc PS3, Line 7: CONFIG_ARCH_BOOTBLOCK_X86_64
Should we add lines for all the different stages instead of assuming? […]
I guess I'm concerned about the PSP Verstage case.
Not sure if the
``` all-y += mode_switch.S ```
will work for us. Maybe that's the part that needs the individual rules?