[coreboot-gerrit] New patch to review for coreboot: d52237c amd/olivehillplus: No global variables for romstage

[Kyösti Mälkki]

Kyösti Mälkki ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7148

-gerrit

commit d52237cb638f0eaebe30ef182bc2330938c5a3f0
Author: Kyösti Mälkki 
Date:   Wed Oct 22 06:42:57 2014 +0300

amd/olivehillplus: No global variables for romstage

These functions are only used for ramstage.

Change-Id: I089230ca625037637c7af061b0939fd981dbdfd2
    Signed-off-by: Kyösti Mälkki 
---
 src/mainboard/amd/olivehillplus/agesawrapper.c | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/src/mainboard/amd/olivehillplus/agesawrapper.c b/src/mainboard/amd/olivehillplus/agesawrapper.c
index 6b4835e..45670bd 100644
--- a/src/mainboard/amd/olivehillplus/agesawrapper.c
+++ b/src/mainboard/amd/olivehillplus/agesawrapper.c
@@ -46,16 +46,18 @@ VOID FchInitS3EarlyRestore (IN FCH_DATA_BLOCK *FchDataPtr);

#define FILECODE UNASSIGNED_FILE_FILECODE

+#ifndef __PRE_RAM__
 /* ACPI table pointers returned by AmdInitLate */
-VOID *DmiTable    = NULL;
-VOID *AcpiPstate  = NULL;
-VOID *AcpiSrat    = NULL;
-VOID *AcpiSlit    = NULL;
-
-VOID *AcpiWheaMce = NULL;
-VOID *AcpiWheaCmc = NULL;
-VOID *AcpiAlib    = NULL;
-VOID *AcpiIvrs    = NULL;
+static void *DmiTable    = NULL;
+static void *AcpiPstate  = NULL;
+static void *AcpiSrat    = NULL;
+static void *AcpiSlit    = NULL;
+
+static void *AcpiWheaMce = NULL;
+static void *AcpiWheaCmc = NULL;
+static void *AcpiAlib    = NULL;
+static void *AcpiIvrs    = NULL;
+#endif

AGESA_STATUS agesawrapper_amdinitcpuio(void)
 {
@@ -287,6 +289,7 @@ AGESA_STATUS agesawrapper_amdinitenv(void)
    return status;
 }

+#ifndef __PRE_RAM__
 VOID* agesawrapper_getlateinitptr (int pick)
 {
    switch (pick) {
@@ -310,6 +313,7 @@ VOID* agesawrapper_getlateinitptr (int pick)
    	return NULL;
    }
 }
+#endif

AGESA_STATUS agesawrapper_amdinitmid(void)
 {
@@ -341,6 +345,7 @@ AGESA_STATUS agesawrapper_amdinitmid(void)
    return status;
 }

+#ifndef __PRE_RAM__
 AGESA_STATUS agesawrapper_amdinitlate(void)
 {
    AGESA_STATUS Status;
@@ -389,6 +394,7 @@ AGESA_STATUS agesawrapper_amdinitlate(void)
    /* AmdReleaseStruct (&AmdParamStruct); */
    return Status;
 }
+#endif

AGESA_STATUS agesawrapper_amdlaterunaptask (
    UINT32 Func,