[coreboot-gerrit] Change in coreboot[master]: cbfs: Enable CBFS mcache on most chipsets

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38424 )

Change subject: cbfs: Enable CBFS mcache on most chipsets
......................................................................

Patch Set 16:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38424/15/src/mainboard/emulation/qe... 
File src/mainboard/emulation/qemu-aarch64/memlayout.ld:

https://review.coreboot.org/c/coreboot/+/38424/15/src/mainboard/emulation/qe... 
PS15, Line 23: CBFS_MCACHE(0x6002D800, 8K)
> We generally make the non-x86 memlayouts static (and not dynamic with using '. […]

Makes sense.

https://review.coreboot.org/c/coreboot/+/38424/15/src/soc/amd/picasso/memlay... 
File src/soc/amd/picasso/memlayout_x86.ld:

https://review.coreboot.org/c/coreboot/+/38424/15/src/soc/amd/picasso/memlay... 
PS15, Line 82: 	VBOOT2_WORK(., VB2_FIRMWARE_WORKBUF_RECOMMENDED_SIZE)
> Not related to my patch, but shouldn't all the ALIGN_COUNTER(64) in memlayout_psp_verstage. […]

You're right.  Thanks. I'll make those changes.