Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39889 )
Change subject: google/hatch/jinlon: Enable top row keys ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39889/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39889/2//COMMIT_MSG@10 PS2, Line 10: PS2 internal keyboard. Please re-flow for 72/75 characters per line.
https://review.coreboot.org/c/coreboot/+/39889/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39889/2/src/mainboard/google/hatch/... PS2, Line 82: ps2k->top_row.keys[8] = TK_KBD_BKLIGHT_UP; /* T9 */ Please use tabs for alignment as below.
https://review.coreboot.org/c/coreboot/+/39889/2/src/mainboard/google/hatch/... PS2, Line 93: Keyboard keyboard